From 675225658c2db4a7c578803336452b73800a4d20 Mon Sep 17 00:00:00 2001 From: Pilzinsel64 Date: Wed, 17 Jul 2024 19:37:36 +0200 Subject: [PATCH] don't apply changes when no changes --- .../NamePlates/NameplateElementChange.cs | 21 +++++++++++-------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/Pilz.Dalamud/Tools/NamePlates/NameplateElementChange.cs b/Pilz.Dalamud/Tools/NamePlates/NameplateElementChange.cs index 5c55c0e..53a7c3a 100644 --- a/Pilz.Dalamud/Tools/NamePlates/NameplateElementChange.cs +++ b/Pilz.Dalamud/Tools/NamePlates/NameplateElementChange.cs @@ -29,16 +29,19 @@ public class NameplateElementChange(NameplateElements element, INamePlateUpdateH public void ApplyChanges() { - StringUpdateFactory.ApplyStringChanges(new() + if (Changes.Any()) { - StringChanges = Changes, - Destination = element switch + StringUpdateFactory.ApplyStringChanges(new() { - NameplateElements.Name => handler.NameParts.Text ??= handler.InfoView.Name, - NameplateElements.Title => handler.TitleParts.Text ??= handler.InfoView.Title, - NameplateElements.FreeCompany => handler.FreeCompanyTagParts.Text ??= handler.InfoView.FreeCompanyTag, - _ => null, - }, - }); + StringChanges = Changes, + Destination = element switch + { + NameplateElements.Name => handler.NameParts.Text ??= handler.InfoView.Name, + NameplateElements.Title => handler.TitleParts.Text ??= handler.InfoView.Title, + NameplateElements.FreeCompany => handler.FreeCompanyTagParts.Text ??= handler.InfoView.FreeCompanyTag, + _ => null, + }, + }); + } } }